8000 ENH add the parameter prefit in the FixedThresholdClassifier by glemaitre · Pull Request #29067 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH add the parameter prefit in the FixedThresholdClassifier #29067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 30, 2024
Merged

ENH add the parameter prefit in the FixedThresholdClassifier #29067

merged 8 commits into from
May 30, 2024

Conversation

glemaitre
Copy link
Member

closes #29062

Add the prefit parameter to the FixedThresholdClassifier allowing to accept a prefitted estimator without refitting it when calling fit.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 21, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a99517f. Link to the linter CI: here

@glemaitre glemaitre added this to the 1.6 milestone May 21, 2024
@glemaitre
Copy link
Member Author

@koaning do you want to have a look at the diff?

koaning
koaning approved these changes May 21, 2024
View reviewed changes
Copy link
@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a fast turn-around! But yeah this looks ace.

jeremiedbb
jeremiedbb approved these changes May 23, 2024
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few comments

glemaitre and others added 3 commits May 24, 2024 10:05
@glemaitre
Copy link
Member Author

The error is unrelated

jeremiedbb
jeremiedbb approved these changes May 24, 2024
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OmarManzoor
OmarManzoor approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion otherwise LGTM. Thanks @glemaitre

@OmarManzoor OmarManzoor merged commit e5ed851 into scikit-learn:main May 30, 2024
30 checks passed
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
adrinjalali added a commit to adrinjalali/scikit-learn that referenced this pull request Oct 29, 2024
@adrinjalali
REVERT ENH add the parameter prefit in the FixedThresholdClassifier (s…
7771691 
…cikit-learn#29067)
@adrinjalali adrinjalali mentioned this pull request Oct 29, 2024
Merged
glemaitre pushed a commit that referenced this pull request Nov 5, 2024
@adrinjalali
REVERT ENH add the parameter prefit in the FixedThresholdClassifier (#…
70aab36 
…29067) (#30172)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koaning koaning koaning approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:model_selection
Projects
Model inspection
Status: Done
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Don't refit in FixedThresholdClassifier when original model is already trained.
4 participants
@glemaitre @koaning @OmarManzoor @jeremiedbb
0