8000 CI Remove unused mkl_no_coverage lock file by lesteve · Pull Request #28061 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Remove unused mkl_no_coverage lock file #28061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

CI Remove unused mkl_no_coverage lock file #28061

merged 1 commit into from
Jan 4, 2024

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Jan 4, 2024 •
edited
Loading

Looks like the build for intel compilers was dropped in #24563 but the lock file is still in the repo and still being updated automatically.

Reading the PR and the associated issue #24525, it is not 100% clear to me whether:

  • we were happy to drop support for Intel compilers (or at least were OK with not testing it)
  • this was a temporary measure which was making going away from distutils easier and one day maybe somebody would add the build again.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 4, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b00491a. Link to the linter CI: here

thomasjpfan
thomasjpfan approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the PR and the associated issue #24525, it is not 100% clear to me whether:

In either case, I am +1 with removing these lock files. If we want to support intel compilers later, we will add then lock files then.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Jan 4, 2024
@jjerphan jjerphan merged commit 3c759c5 into scikit-learn:main Jan 4, 2024
fcharras pushed a commit 8000 to fcharras/scikit-learn that referenced this pull request Jan 9, 2024
@lesteve @fcharras
CI Remove unused mkl_no_coverage lock file (scikit-learn#28061)
0b5b550
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jan 17, 2024
@lesteve @jeremiedbb
CI Remove unused mkl_no_coverage lock file (scikit-learn#28061)
808a10b
jeremiedbb pushed a commit that referenced this pull request Jan 17, 2024
@lesteve @jeremiedbb
CI Remove unused mkl_no_coverage lock file (#28061)
eb6330c
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@lesteve @glemaitre
CI Remove unused mkl_no_coverage lock file (scikit-learn#28061)
1b49732
@lesteve lesteve deleted the remove-mkl-no-coverage branch June 27, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
Build / CI Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesteve @thomasjpfan @jjerphan
0