-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
MNT replace Cython loss functions in SGD part 3 #28037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jjerphan
merged 16 commits into
scikit-learn:main
from
lorentzenchr:replace_sgd_with_common_loss_part_3
Jul 24, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f6c3bda
MNT replace Cython loss functions in SGD part 1
lorentzenchr df4bdca
MNT change argument order in SAG
lorentzenchr 7ddbcd5
MNT inherit from CyLossFunction
lorentzenchr bc2be3c
ENH replace Log, SquaredLoss and Huber with common losses
lorentzenchr 68f35c3
MNT remove SGD extension type LossFunction
lorentzenchr aefb44f
MNT remove Hing and ModifiedHuber from __init__
lorentzenchr 51954fe
ENH use CyHalfMultinomialLoss in SAGA
lorentzenchr 0e3db39
MNT remove SAGA MultinomialLogLoss
lorentzenchr 2034dee
Merge branch 'main' into replace_sgd_with_common_loss_part_3
lorentzenchr 40613b0
Merge branch 'main' into replace_sgd_with_common_loss_part_3
lorentzenchr de7c66c
Merge branch 'main' into replace_sgd_with_common_loss_part_3
lorentzenchr 830dd12
Merge branch 'main' into replace_sgd_with_common_loss_part_3
OmarManzoor dfc84f4
Update sklearn/_loss/_loss.pyx.tp
OmarManzoor 59b1df6
Update sklearn/_loss/_loss.pyx.tp
OmarManzoor 0d4fbe5
Update sklearn/_loss/tests/test_loss.py
OmarManzoor 09a6cc2
Address PR suggestions
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is much nicer to be able to use fused types directly!