8000 FEA metadata routing for permutation_test_score by KartikeyBartwal · Pull Request #27674 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FEA metadata routing for permutation_test_score #27674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

FEA metadata routing for permutation_test_score #27674

wants to merge 2 commits into from

Conversation

KartikeyBartwal
Copy link

Reference Issues/PRs

Towards #22893

What does this implement/fix? Explain your changes.

Adds metadata routing to VotingClassifier

Any other comments?

Please do give your advise on how and where to research to help me to fulfil my commitment if the PR doesn't do the job well

@github-actions
Copy link

❌ Linting issues

This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit hooks. Instructions to enable them can be found here.

You can see the details of the linting issues under the lint job here

ruff

ruff detected issues. Please run ruff --fix --show-source . locally, fix the remaining issues, and push the changes. Here you can see the detected issues. Note that the installed ruff version is ruff=0.1.3.


sklearn/tests/test_metaestimators_metadata_routing.py:281:26: F821 Undefined name `permutation_test_score`
    |
279 |     },
280 |     {
281 |         "metaestimator": permutation_test_score,
    |                          ^^^^^^^^^^^^^^^^^^^^^^ F821
282 |         "X": X,
283 |         "y": y,
    |

Found 1 error.

mypy

mypy detected issues. Please fix them locally and push the changes. Here you can see the detected issues. Note that the installed mypy version is mypy=1.3.0.


sklearn/externals/_arff.py:782: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
sklearn/tests/test_metaestimators_metadata_routing.py:281: error: Name "permutation_test_score" is not defined  [name-defined]
Found 1 error in 1 file (checked 541 source files)

Generated for commit: 3f5791f. Link to the linter CI: here

@glemaitre glemaitre marked this pull request as draft October 30, 2023 10:21
@glemaitre glemaitre changed the title FEA metadata routing for test_permutation_score FEA metadata routing for permutation_test_score Oct 30, 2023
@glemaitre
Copy link
Member

I put this PR in draft because this is not ready to be reviewed.

If you intend to add metadata routing for permutation_test_score, I would advise to have a look at the changes done for the cross_val_* methods: #26896

You will need similar changes here with a bit less boilerplate that have already been merged in main.

You probably want to edit your summary because you mentioned modifying the VotingClassifier estimator.

@KartikeyBartwal
Copy link
Author

Thank you for the guidance I'll start working right away

@adrinjalali
Copy link
Member

Not really ready for review and stale. You might want to look at issues which are better to start with. This one is not a good one as the first few PRs.

@adrinjalali adrinjalali closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KartikeyBartwal @glemaitre @adrinjalali @Kartikey-Bartwal
0