8000 MAINT Remove flake8 mentions/ignore comments by lucyleeow · Pull Request #26988 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

MAINT Remove flake8 mentions/ignore comments #26988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/tutorial/machine_learning_map/pyparsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
#
# flake8: noqa
# ruff: noqa

__doc__ = \
"""
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# flake8: noqa
# ruff: noqa
"""
========================================
Release Highlights for scikit-learn 0.23
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# flake8: noqa
# ruff: noqa
"""
========================================
Release Highlights for scikit-learn 0.24
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# flake8: noqa
# ruff: noqa
"""
=======================================
Release Highlights for scikit-learn 1.0
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# flake8: noqa
# ruff: noqa
"""
=======================================
Release Highlights for scikit-learn 1.1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# flake8: noqa
# ruff: noqa
"""
=======================================
Release Highlights for scikit-learn 1.2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# flake8: noqa
# ruff: noqa
"""
=======================================
Release Highlights for scikit-learn 1.3
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ exclude=[
# + E501 (line too long) because keeping it < 88 in cython
# often makes code less readable.
ignore = [
# check ignored by default in flake8. Meaning unclear.
# multiple spaces/tab after comma
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have just put the rule here. Also I don't think it is ignored by default by ruff

'E24',
# space before : (needed for how black formats slicing)
'E203',
Expand Down
2 changes: 1 addition & 1 deletion sklearn/utils/tests/test_pprint.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@


# Ignore flake8 (lots of line too long issues)
# flake8: noqa
# ruff: noqa


# Constructors excerpted to test pprinting
Expand Down
0