8000 FIX make CalibratedClassifierCV not enforce sample alignment for fit_params by adrinjalali · Pull Request #25805 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX make CalibratedClassifierCV not enforce sample alignment for fit_params #25805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2023
Merged

FIX make CalibratedClassifierCV not enforce sample alignment for fit_params #25805

merged 2 commits into from
Mar 10, 2023

Conversation

adrinjalali
Copy link
Member

Fixes #25696

This PR removes the enforcement of sample alignment for fit_params in CalibratedClassifierCV, which makes it the same as other estimators we have.

It also removes the old test which was ensuring the enforcement, and introduces a new test to make sure non-sample-aligned data is accepted and passed along.

@adrinjalali adrinjalali requested a review from glemaitre March 10, 2023 12:39
@adrinjalali adrinjalali added Quick Review For PRs that are quick to review module:calibration labels Mar 10, 2023
glemaitre
glemaitre approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @adrinjalali

thomasjpfan
thomasjpfan approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 30bf6f3 into scikit-learn:main Mar 10, 2023
@adrinjalali adrinjalali deleted the calibrate-check branch March 10, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:calibration Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CalibratedClassifierCV fails on lgbm fit_params
3 participants
@adrinjalali @thomasjpfan @glemaitre
0