8000 FIX `transform_output` set in `config_context` not preserved in the Transformer object? by ravwojdyla · Pull Request #25288 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX transform_output set in config_context not preserved in the Transformer object? #25288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

FIX transform_output set in config_context not preserved in the Transformer object? #25288

wants to merge 1 commit into from

Conversation

ravwojdyla
Copy link
Contributor

Reference Issues/PRs

Fixes: #25287

What does this implement/fix? Explain your changes.

Implements the idea from #25287, to provide a default init _SetOutputMixin to capture the transform_output if not default. But I'm obviously open to suggestions for better solution, and I'm happy to adjust this PR.

@ravwojdyla ravwojdyla force-pushed the keep-transform-out-config branch from 303810c to 71c4c41 Compare January 4, 2023 13:38
@ravwojdyla ravwojdyla mentioned this pull request Jan 4, 2023
Closed
@glemaitre
Copy link
Member

Closing as per explained in #25287 (comment). A documentation improvement would be better.

@ravwojdyla ravwojdyla closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transform_output set in config_context not preserved in the Transformer object?
2 participants
@ravwojdyla @glemaitre
0