8000 CI Use "any" global random seed and run float32 tests in Azure docker-based builds by lesteve · Pull Request #24201 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Use "any" global random seed and run float32 tests in Azure docker-based builds #24201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

CI Use "any" global random seed and run float32 tests in Azure docker-based builds #24201

wants to merge 2 commits into from

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Aug 18, 2022 •
edited
Loading

The BUILD_REASON environment variable is not forwarded to the container, so that means that the nightly docker-based builds in Azure don't use "any" for the global random seed and don't run the 32bit tests:

scikit-learn/build_tools/azure/test_script.sh

Lines 20 to 30 in 9aae2ad

if [[ "$BUILD_REASON" == "Schedule" ]]; then
# Enable global random seed randomization to discover seed-sensitive tests
# only on nightly builds.
# https://scikit-learn.org/stable/computing/parallelism.html#environment-variables
export SKLEARN_TESTS_GLOBAL_RANDOM_SEED="any"
# Enable global dtype fixture for all nightly builds to discover
# numerical-sensitive tests.
# https://scikit-learn.org/stable/computing/parallelism.html#environment-variables
export SKLEARN_RUN_FLOAT32_TESTS=1
fi

You can actually double-check in the latest scheduled build for the Debian 32 build that you can't find any output that SKLEARN_TESTS_GLOBAL_RANDOM_SEED.

As seen in #24198, I am expecting the Debian 32bit build to fail. I'll launch the PyPy build (which is the only other build using docker-posix.yml) as well to double-check.

@lesteve
Copy link
Member Author
lesteve commented Aug 18, 2022 •
edited
Loading

As seen in #24198, I am expecting the Debian 32bit build to fail. I'll launch the PyPy build (which is the only other build using docker-posix.yml) as well to double-check.

Actually it did not fail, since float32 tests are not run. I opened #24202 to be able to do that with a commit message.

#24198 should be merged first, since some float32 tests need to be fixed first, before we run them in the scheduled build.

@ogrisel
Copy link
Member
ogrisel commented Aug 23, 2022 •
edited
Loading

It seems that this was fixed in main (via #24202) as there is nothing left in this PR after the merge.

Closing.

@ogrisel ogrisel closed this Aug 23, 2022
@lesteve
Copy link
Member Author
lesteve commented Aug 23, 2022

I think this still needs to be addressed, reopening.

@lesteve lesteve reopened this Aug 23, 2022
@lesteve
Copy link
Member Author
lesteve commented Aug 23, 2022 •
edited
Loading

Actually it was merged as part of #24202, which was not intentional oh well, closing then ...

@lesteve lesteve closed this Aug 23, 2022
@lesteve lesteve mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Review 4ECF ers
No reviews
Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @ogrisel
0