-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
WIP ENH Added auto
option to FastICA.whiten_solver
#23616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Micky774
wants to merge
20
commits into
scikit-learn:main
Choose a base branch
from
Micky774:whiten_auto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a2c03e7
Added `auto` option w/ heuristic
Micky774 3230bd5
Added changelog entry
Micky774 a18dd97
Merge branch 'main' into whiten_auto
Micky774 d697fff
Added default param override to `test_dosctring_parameters`
Micky774 1d46633
Corrected docstring
Micky774 9ba991b
Merge branch 'main' into whiten_auto
Micky774 399edb5
Merge branch 'main' into whiten_auto
Micky774 3e688ff
Merge branch 'main' into whiten_auto
Micky774 a4f796a
Merge branch 'whiten_auto' of https://github.com/Micky774/scikit-lear…
Micky774 a841ee9
Simplified FutureWarning avoidance using filterwarnings
Micky774 a003cd7
Updated docstring
Micky774 cbf6fce
Merge branch 'main' into whiten_auto
Micky774 0a312ce
Simplified versionadded directives
Micky774 bf7eb8c
Merge branch 'main' into whiten_auto
Micky774 95bf7f4
Apply suggestions from code review
Micky774 3710fca
Made tests explicit w/ setting `whiten_solver` keyword
Micky774 bc25386
Slightly modified test
Micky774 f0a4842
Added more explicit information to warning
Micky774 7b1f72b
Merge branch 'main' into whiten_auto
Micky774 0ec6164
Merge branch 'main' into whiten_auto
Micky774 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.