8000 CI Fix don't run all random seeds all the time by jeremiedbb · Pull Request #23190 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Fix don't run all random seeds all the time #23190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 22, 2022
Merged

CI Fix don't run all random seeds all the time #23190

merged 7 commits into from
Apr 22, 2022

Conversation

jeremiedbb
Copy link
Member

Fixes #23185

Since #23026, it turns out that the CI runs for all random seeds all the time, making it take a lot more time.

@jeremiedbb
Copy link
Member Author

The run selected test based on commit message still works (deb5fd3). Now let's check that we don't run all randoms seeds by default.

glemaitre
glemaitre approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb
Copy link
Member Author
jeremiedbb commented Apr 22, 2022 •
edited
Loading

random seeds are not all run anymore and timings are back to normal (ce5fdd4). Let's merge quickly

@jeremiedbb jeremiedbb merged commit 24f3006 into scikit-learn:main Apr 22, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
@jeremiedbb @jjerphan
CI Fix don't run all random seeds all the time (scikit-learn#23190)
55ac9ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Build / CI No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The azure CI times out more and more often
2 participants
@jeremiedbb @glemaitre
0