DOC Update notebook style for plot_bayesian_ridge_curvefit #22916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilke
reviewed
Mar 22, 2022
| @@ -28,33 +28,36 @@ | |||
|
|
|||
| # Author: Yoshihiro Uchida <nimbus1after2a1sun7shower@gmail.com> | |||
|
|
|||
| # %% | |||
| # Generate sinusoidal data with noise | |||
| # ----------------------------------- | |||
| import numpy as np | |||
| import matplotlib.pyplot as plt | |||
There was a problem hiding this comment.
I suggest moving this import down to the plotting code block where it is used.
Comment on lines
59
to
61
| from sklearn.linear_model import BayesianRidge | ||
|
|
||
| reg = BayesianRidge(tol=1e-6, fit_intercept=False, compute_score=True) |
There was a problem hiding this comment.
Based on your PR comment, I suspect you meant to move these lines into the previous fitting block rather than this plotting one. I agree that the fitting block would be a better place for these lines given that this final block is only concerned with plotting.
There was a problem hiding this comment.
Done.
Thanks for taking the time to review!
|
LGTM, merging, thanks a lot! |
|
And thanks @jsilke for the helpful comments! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
…arn#22916) Co-authored-by: Juan Gomez <jgomez75@gatech.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC Update notebook style for plot_bayesian_ridge_curvefit
Reference Issues/PRs
Update examples/linear_model/plot_bayesian_ridge_curvefit.py to notebook style, Issue #22406
What does this implement/fix? Explain your changes.
Split into 3 sections
Moved the following code