CI: refactor Azure CI install script #22567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Feb 21, 2022
build_tools/azure/install.sh
Outdated
| # The "build_clib" command is implicitly used to build "libsvm-skl". | ||
| # To compile with a different compiler, we also need to specify the | ||
| # compiler for this command | ||
| python setup.py build_ext --compiler=intelem -i build_clib --compiler=intelem |
There was a problem hiding this comment.
I think we still have to wait till scikit_learn_install to run build_ext so we use the correct python environment?
Currently on main, the conda environment is created first and setup.py build_ext is called in that enviornment.
There was a problem hiding this comment.
Good catch I fixed this and use [icc-build] in my last commit to make sure to test the BUILD_WITH_ICC logic and the CI passes (here is the log)
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
plus move post_pyton_environment_install to scikit_learn_install
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jeremiedbb
approved these changes
Feb 22, 2022
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
|
The CI is green merging, thanks for the reviews! |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal is to make it easier to move to lock files #22448, i.e. to isolate Python environment creation from the rest.
This makes it easier to grok at the cost of making it a bit harder to follow what is happening in a particular build.
I split the install in four steps:
pre_python_environment_install: apt-get and other similar thingspython_environment_install: installing the python environment as the name says-I ended up merging this step withpost_python_environment_install:setup_ccacheand showing installed libraries. It could be removed and two lines added to the beginning ofscikit_learn_installif deemed preferrablescikit_learn_installscikit_learn_install: environment variable setup for compilation, whether or not to use build isolation,ccache -safterwards