TST invalid init parameters for losses #22407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
thomasjpfan
approved these changes
Feb 7, 2022
glemaitre
reviewed
Feb 9, 2022
glemaitre
reviewed
Feb 9, 2022
thomasjpfan
reviewed
Feb 9, 2022
glemaitre
approved these changes
Feb 11, 2022
glemaitre
reviewed
Feb 14, 2022
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Feb 23, 2022
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Came up in #21800 (comment).
What does this implement/fix? Explain your changes.
This PR adds checks and tests for init parameter of losses
PinballLossandHalfTweedieDeviance.