From 3eeed65168b934c1a6ab1cb999f90fe58a6676b1 Mon Sep 17 00:00:00 2001 From: Olivier Grisel Date: Mon, 6 Sep 2021 16:12:58 +0200 Subject: [PATCH 1/2] MAINT missing what's new entry for PR-19401 --- doc/whats_new/v1.0.rst | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/doc/whats_new/v1.0.rst b/doc/whats_new/v1.0.rst index d9dcf8757bc68..b028b04346690 100644 --- a/doc/whats_new/v1.0.rst +++ b/doc/whats_new/v1.0.rst @@ -824,13 +824,6 @@ Changelog - |Fix| Improves compatibility of :func:`tree.plot_tree` with high DPI screens. :pr:`20023` by `Thomas Fan`_. -:mod:`sklearn.feature_extraction` -.................................. - -- |Fix| Fixed a bug in :func:`image._to_graph` where singleton - connected components were not handled properly, resulting in a wrong - vertex indexing. :pr:`18964` by `Bertrand Thirion`_. - - |Fix| Fixed a bug in :class:`tree.DecisionTreeClassifier`, :class:`tree.DecisionTreeRegressor` where a node could be split whereas it should not have been due to incorrect handling of rounding errors. @@ -842,6 +835,18 @@ Changelog and will be removed in 1.2. :pr:`20272` by :user:`Jérémie du Boisberranger `. +:mod:`sklearn.feature_extraction` +................................. + +- |Fix| Fixed a bug in :func:`feature_extraction.image._to_graph` where + singleton connected components were not handled properly, resulting in a + wrong vertex indexing. :pr:`18964` by `Bertrand Thirion`_. + +- |Fix| Raise a warning in class:`feature_extraction.text.CountVectorizer` + with `lowercase=True` when there are vocabulary entries with uppercase + characters to avoid silent misses in the resulting feature vectors. + :pr:`19401` by :user:`Zito Relova ` + :mod:`sklearn.utils` .................... From 95f457587dae78a7f0ec4f172696a2b146bce74e Mon Sep 17 00:00:00 2001 From: Olivier Grisel Date: Mon, 6 Sep 2021 18:30:47 +0200 Subject: [PATCH 2/2] Consolidate sklearn.feature_extraction entries + fix refs --- doc/whats_new/v1.0.rst | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/doc/whats_new/v1.0.rst b/doc/whats_new/v1.0.rst index b028b04346690..ec538db7b11f0 100644 --- a/doc/whats_new/v1.0.rst +++ b/doc/whats_new/v1.0.rst @@ -389,14 +389,24 @@ Changelog :mod:`sklearn.feature_extraction` ................................. -- |Fix| Fixed a bug in :class:`feature_extraction.HashingVectorizer` where some - input strings would result in negative indices in the transformed data. - :pr:`19035` by :user:`Liu Yu `. +- |Fix| Fixed a bug in :class:`feature_extraction.text.HashingVectorizer` + where some input strings would result in negative indices in the transformed + data. :pr:`19035` by :user:`Liu Yu `. - |Fix| Fixed a bug in :class:`feature_extraction.DictVectorizer` by raising an error with unsupported value type. :pr:`19520` by :user:`Jeff Zhao `. +- |Fix| Fixed a bug in :func:`feature_extraction.image.img_to_graph` + and :func:`feature_extraction.image.grid_to_graph` where singleton connected + components were not handled properly, resulting in a wrong vertex indexing. + :pr:`18964` by `Bertrand Thirion`_. + +- |Fix| Raise a warning in :class:`feature_extraction.text.CountVectorizer` + with `lowercase=True` when there are vocabulary entries with uppercase + characters to avoid silent misses in the resulting feature vectors. + :pr:`19401` by :user:`Zito Relova ` + :mod:`sklearn.feature_selection` ................................ @@ -835,18 +845,6 @@ Changelog and will be removed in 1.2. :pr:`20272` by :user:`Jérémie du Boisberranger `. -:mod:`sklearn.feature_extraction` -................................. - -- |Fix| Fixed a bug in :func:`feature_extraction.image._to_graph` where - singleton connected components were not handled properly, resulting in a - wrong vertex indexing. :pr:`18964` by `Bertrand Thirion`_. - -- |Fix| Raise a warning in class:`feature_extraction.text.CountVectorizer` - with `lowercase=True` when there are vocabulary entries with uppercase - characters to avoid silent misses in the resulting feature vectors. - :pr:`19401` by :user:`Zito Relova ` - :mod:`sklearn.utils` ....................