8000 FIX use correct formulation for ExpSineSquared kernel by glemaitre · Pull Request #20070 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX use correct formulation for ExpSineSquared kernel #20070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

FIX use correct formulation for ExpSineSquared kernel #20070

wants to merge 8 commits into from

Conversation

glemaitre
Copy link
Member
@glemaitre glemaitre commented May 10, 2021 •
edited
Loading

closes #19343
closes #9824

TODO:

@glemaitre glemaitre marked this pull request as draft May 10, 2021 09:57
@glemaitre glemaitre mentioned this pull request May 10, 2021
Open
@glemaitre glemaitre mentioned this pull request May 11, 2021
Closed
@glemaitre glemaitre added this to the 1.0 milestone May 11, 2021
@adrinjalali
Copy link
Member

@glemaitre you still want this in v1.0?

@glemaitre
Copy link
Member Author

We need some cythonization here and it would be useful to come back once the PR of @jjerphan is merged.

@glemaitre glemaitre modified the milestones: 1.0, 1.1 Aug 30, 2021
@jjerphan
Copy link
Member
jjerphan commented Aug 30, 2021 •
edited
Loading

Indeed #20254 might help this PR.

Edit: #21218 is the dedicated (yet draft) PR which builds on top of #20254.

@jeremiedbb jeremiedbb modified the milestones: 1.1, 1.2 Mar 25, 2022
@jeremiedbb
Copy link
Member

Seems that this needs a lot more work. Very unlikely to fit in 1.1

@glemaitre glemaitre modified the milestones: 1.2, 1.3 Nov 16, 2022
@jeremiedbb jeremiedbb modified the milestones: 1.3, 1.4 Jun 8, 2023
@glemaitre glemaitre modified the milestones: 1.4, 1.5 Dec 7, 2023
@jeremiedbb
Copy link
Member

wont make it for 1.5. It's been in draft mode for several releases. I'm removing it from any milestone. Feel free to add it back when it's ready.

@jeremiedbb jeremiedbb removed this from the 1.5 milestone Apr 25, 2024
@kyrajeep
Copy link
kyrajeep commented Jun 5, 2024

I took a look at the code changes and #21218 #20254. Is there something I can do for this issue still?

@adrinjalali
Copy link
Member

@jjerphan the PRs you mentioned here are both closed. Could you maybe give us an update on the status of this part of the project?

@jjerphan
Copy link
Member
jjerphan commented Jun 5, 2024

Yes!

Both PRs have been superseded by #21462 which addressed a slightly different class of contributions than this one, namely reductions over pairwise distances matrices. In this regards, potential next efforts are non-exhaustively listed in #25888, and people should feel free to pick items or suggest other ones.

There are other patterns of computations over dissimilarity matrices or kernel matrices which are similar but which aren't covered yet (we need to decide whether they could be relevant or not for scikit-learn, I think).

I would refer you to other projects like keops and falkon which perfected the implementations of such patterns on GPU.

Though I would like to help the project on this front, I unfortunately have other commitments for now.

@kyrajeep
Copy link
kyrajeep commented Jun 5, 2024

Wonderful! I am going through the EuroScipy 2022 slides linked and will choose one of the tasks in #25888 and create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:gaussian_process Needs work
Projects
Maintenance
Status: In Progress
Milestone
No milestone
5 participants
@glemaitre @adrinjalali @jjerphan @jeremiedbb @kyrajeep
0