8000 API Removes tol=None option from HistGradientBoosting* by thomasjpfan · Pull Request #19296 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

API Removes tol=None option from HistGradientBoosting* #19296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2021
Merged

API Removes tol=None option from HistGradientBoosting* #19296

merged 2 commits into from
Jan 29, 2021

Conversation

thomasjpfan
Copy link
Member
@thomasjpfan thomasjpfan commented Jan 29, 2021 •
edited by NicolasHug
Loading

Reference Issues/PRs

Fixes #19246

What does this implement/fix? Explain your changes.

This feature is already enabled by setting tol=0.

@thomasjpfan
API Removes tol=None option from HistGradient*
< 8000 div class="pr-1 d-md-inline-block d-none">
7cf3494
NicolasHug
NicolasHug approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member
@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green ;)

lorentzenchr
lorentzenchr reviewed Jan 29, 2021
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test for None in test_init_parameters_validation?

@ogrisel
Copy link
Member
ogrisel commented Jan 29, 2021 •
edited
Loading

Should we test for None in test_init_parameters_validation?

I don't think so. The natural error message from Python you get when you pass None is explicit enough. Not need to test it I believe. I will push a commit to update the failing test.

ogrisel
ogrisel approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's merge.

@ogrisel ogrisel merged commit b943324 into scikit-learn:main Jan 29, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
@adrinjalali adrinjalali mentioned this pull request Sep 3, 2021
Closed
6 tasks
@eddiebergman eddiebergman mentioned this pull request Nov 15, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentzenchr lorentzenchr lorentzenchr left review comments

@ogrisel ogrisel ogrisel approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
module:ensemble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should tol=None be removed from HistGradientBoosting*?
4 participants
@thomasjpfan @ogrisel @NicolasHug @lorentzenchr
0