8000 MNT minimally revert strict_mode by glemaitre · Pull Request #18905 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT minimally revert strict_mode #18905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2020
Merged

MNT minimally revert strict_mode #18905

merged 3 commits into from
Nov 25, 2020

Conversation

@glemaitre
Copy link
Member
@glemaitre glemaitre commented Nov 25, 2020

Revert #17361

However, instead of reverting the PR, we only remove strict_mode to have the minimum number of changes and keep changes as function renaming, etc.

@glemaitre glemaitre added this to the 0.24 milestone Nov 25, 2020
NicolasHug
NicolasHug approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member
@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glemaitre , LGTM

@glemaitre @NicolasHug
Update sklearn/utils/estimator_checks.py
26dce48 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
adrinjalali
adrinjalali approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @glemaitre

@adrinjalali adrinjalali merged commit ad3c288 into scikit-learn:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

+1 more reviewer

@NicolasHug NicolasHug NicolasHug approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module:utils

Projects

None yet

Milestone

0.24

Development

Successfully merging this pull request may close these issues.

3 participants

@glemaitre @NicolasHug @adrinjalali
0