8000 DOC Forces word-break of code blocks to not break by thomasjpfan · Pull Request #18885 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Forces word-break of code blocks to not break #18885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2020
Merged

DOC Forces word-break of code blocks to not break #18885

merged 2 commits into from
Nov 22, 2020

Conversation

thomasjpfan
Copy link
Member

Current the docs table in multiclass and multilabel classification looks like:

Screen Shot 2020-11-20 at 3 36 56 PM

This PR fixes this to look like:

Screen Shot 2020-11-20 at 3 38 19 PM

@amueller
Copy link
Member

lgtm. The failure is openml related so I assume it's unrelated?

@jnothman jnothman merged commit 3532084 into scikit-learn:master Nov 22, 2020
@cmarmo
Copy link
Contributor
cmarmo commented Nov 23, 2020

@thomasjpfan same issue here. Shall we just remove the word-break css attribute from theme.css? If I understand correctly the default behaviour is 'normal', and it is the needed behaviour.

@cmarmo cmarmo mentioned this pull request Nov 23, 2020
Closed
@thomasjpfan
Copy link
Member Author

Shall we just remove the word-break css attribute from theme.css? If I understand correctly the default behaviour is 'normal', and it is the needed behaviour.

@cmarmo Are you referring to the word-break for the p tag? I would be okay with switching this to normal to avoid having formatting issues.

@cmarmo
Copy link
Contributor
cmarmo commented Nov 23, 2020

@cmarmo Are you referring to the word-break for the p tag? I would be okay with switching this to normal to avoid having formatting issues.

I'm referring to all word-break in theme.css, but then I noticed that bootstrap set some of them. I've proposed #18899: I didn't find any rendering issue with it, but I've sampled the site at random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @amueller @cmarmo @jnothman
0