10000 DOC Fix LaTeX hyperref error: "\pdfendlink ended up in different nesting level than \pdfstartlink" by cmarmo · Pull Request #18213 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Fix LaTeX hyperref error: "\pdfendlink ended up in different nesting level than \pdfstartlink" #18213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2020
Merged

DOC Fix LaTeX hyperref error: "\pdfendlink ended up in different nesting level than \pdfstartlink" #18213

merged 2 commits into from
Aug 21, 2020

Conversation

cmarmo
Copy link
Contributor
@cmarmo cmarmo commented Aug 20, 2020

What does this implement/fix? Explain your changes.

Since 618e625 latex build is failing with error

\pdfendlink ended up in different nesting level than \pdfstartlink

This PR fix this issue forcing references in a \hbox and fixing a unnumbered reference.

Any other comments?

Thanks stackoverflow... :)

@alfaro96
Copy link
Member

I am thinking that it would be interesting to trigger the latex build in this PR to ensure that this error:

\pdfendlink ended up in different nesting level than \pdfstartlink

is not issued.

@glemaitre
Copy link
Member

Do we build the pdf if we include [doc build] in the title of the commit?

Not related to this PR, but are we still building a PDF? I think that @rth was advocating to drop this to which I would agree with.

@cmarmo
Copy link
Contributor Author
cmarmo commented Aug 20, 2020

Do we build the pdf if we include [doc build] in the title of the commit?

Right! I've just discovered that [doc build] triggers make dist not only make html

Not related to this PR, but are we still building a PDF? I think that @rth was advocating to drop this to which I would agree with.

This is waiting for #17564

@cmarmo
Copy link
Contributor Author
cmarmo commented Aug 20, 2020

Do we build the pdf if we include [doc build] in the title of the commit?

Right! I've just discovered that [doc build] triggers make dist not only make html

ERRATA CORRIGE
the make dist is triggered only when the PR is merged: I don't know how to trigger the pdf build...

@thomasjpfan thomasjpfan mentioned this pull request Aug 20, 2020
Closed
@thomasjpfan
Copy link
Member

I am trying this fix out in #18217 . When that passes, we can merge this PR.

@alfaro96
Copy link
Member
alfaro96 commented Aug 20, 2020 •
edited
Loading

I am trying this fix out in #18217 . When that passes, we can merge this PR.

The LaTeX build is working in #18217. We can close #18217 and merge this PR.

@glemaitre glemaitre merged commit c24e749 into scikit-learn:master Aug 21, 2020
@glemaitre
Copy link
Member

Thanks @cmarmo

jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@cmarmo @jayzed82
MNT/DOC Add preamble adding hbox around href. Fix unnumbered ref. (sc…
fbc6d8d 
…ikit-learn#18213)
@cmarmo cmarmo deleted the latexfix branch July 11, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@alfaro96 alfaro96 alfaro96 approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmarmo @alfaro96 @glemaitre @thomasjpfan
0