8000 OneVsOneClassifier: added an example to the documentation by j0rd1smit · Pull Request #16700 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

OneVsOneClassifier: added an example to the documentation #16700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

j0rd1smit
Copy link
Contributor

The to do list in issue #3846 mentioned that the OneVsOneClassifier classifier needed an example in its documentation. I saw the was already an example in the user guide so I added this example to the documentation.

Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes but it looks good

@j0rd1smit
Copy link
Contributor Author

@glemaitre I have added the requested changes

Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks @j0rd1smit

Comment on lines 530 to 537
8000
>>> clf.predict(X_test)
array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 2, 1, 2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1, 1, 1, 1, 1, 1, 1, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think showing the output of even only one input i.e. X_test[0, :] should be enough.

@j0rd1smit j0rd1smit requested a review from glemaitre March 17, 2020 15:16
@Malesche Malesche mentioned this pull request Mar 29, 2020
23 tasks
@glemaitre
Copy link
Member

@j0rd1smit I just pushed a commit with the suggestion of @adrinjalali and I will merge when the CIs are happy. Thanks for your work.

@glemaitre glemaitre merged commit a4dcada into scikit-learn:master May 12, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 18, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0