8000 MRG Class weight refactor by amueller · Pull Request #1485 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MRG Class weight refactor #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 3, 2013
Merged

MRG Class weight refactor #1485

merged 14 commits into from
Jan 3, 2013

Conversation

@amueller
Copy link
Member
@amueller amueller commented Dec 22, 2012

New PR as I messed up #1464.

@ogrisel gave his +1 there.

@erg your comments would still be welcome.

Also more comments by @larsmans and @mblondel ;)

@amueller
Copy link
Member Author
amueller commented Dec 24, 2012

Sorry for pestering but I would really like to merge this soon, as I want to work on #1411, which I think is release critical.

@amueller amueller mentioned this pull request Dec 24, 2012
Merged
@ogrisel
Copy link
Member
ogrisel commented Dec 29, 2012

+1 again

@amueller amueller mentioned this pull request Jan 2, 2013
Closed
mblondel
mblondel reviewed Jan 2, 2013
View reviewed changes
doc/whats_new.rst
Copy link
Member
@mblondel mblondel Jan 2, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably be consistent in the whole scikit for this (test_common...). Of course, this is not in the scope of this PR.

Copy link
Member Author
@amueller amueller Jan 2, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a test, that would actually test for strings, but it is commented out still, because something in the SGD didn't like it. I wasn't in the mood to investigate but will after some my current PRs are merged.

@mblondel
Copy link
Member
mblondel commented Jan 2, 2013

Apart from my comment, +1.

amueller added 14 commits January 3, 2013 13:21
@amueller amueller merged commit 1c1538a into scikit-learn:master Jan 3, 2013
@amueller
Copy link
Member Author
amueller commented Jan 3, 2013

Moved compute_class_weights to dedicated file and merged.

@amueller amueller deleted the class_weight_refactor branch January 3, 2013 12:29
@ogrisel
Copy link
Member
ogrisel commented Jan 3, 2013

\o/

@amueller
Copy link
Member Author
amueller commented Jan 3, 2013

🍻

@coveralls
Copy link
coveralls commented Mar 8, 2014

Coverage Status

Changes Unknown when pulling 1c1538a on amueller:class_weight_refactor into * on scikit-learn:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.13

Development

Successfully merging this pull request may close these issues.

4 participants

@amueller @ogrisel @mblondel @coveralls
0