8000 MAINT: simpler binder requirements.txt by lesteve · Pull Request #14832 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT: simpler binder requirements.txt #14832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2019
Merged

MAINT: simpler binder requirements.txt #14832

merged 1 commit into from
Aug 28, 2019

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Aug 28, 2019

Mentioned by @ogrisel in #14719 (comment).

I tested this by doing:
pip install -r .binder/requirements.txt which does install scikit-learn dev version.

The advantages:

  • simpler
  • no need to remember to update .binder/requirements.txt after a new release.

rth
rth approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

@rth rth merged commit 99d6000 into scikit-learn:master Aug 28, 2019
@rth rth changed the title MAINT: simpler binder requirementst.txt to install scikit-learn dev version MAINT: simpler binder requirements.txt Aug 28, 2019
@lesteve lesteve deleted the tweak-binder-requirements branch August 28, 2019 19:00
@thomasjpfan thomasjpfan mentioned this pull request Sep 24, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @rth
0