8000 [WIP] DOC documentation for default values in linear_models by shahules786 · Pull Request #14505 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[WIP] DOC documentation for default values in linear_models #14505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] DOC documentation for default values in linear_models #14505

wants to merge 2 commits into from

Conversation

shahules786
Copy link

Reference Issues/PRs

What does this implement/fix? Explain your changes.

I added default values to documentation of each parameter which were missing in both PassiveAggressiveRegressor and PassiveAggressiveClassifier functions.

Any other comments?

@rth
Copy link
Member
rth commented Jul 29, 2019

Please edit the title to something describing this PR.

@shahules786 shahules786 changed the title Mybranch documentation for default values in linear_models Jul 29, 2019
@shahules786
Copy link
Author

@rth Done .

@amueller
Copy link
Member

I'd be ok with this but I think we want to get rid of the "optional", also see the discussion in #12356.
For reference, this fixes part of #14452.

@shahules786
Copy link
Author
shahules786 commented Jul 30, 2019 •
edited
Loading

@amueller @rth
So you want me to correct it for optional parameters like

sample_weight : array-like or None
The sample weights, ignored by default (None).

@adrinjalali
Copy link
Member

@maverick100 it'd be nice if you could try to have them in a format suggested in the two referenced issues.

@glemaitre
Copy link
Member

Let's wait for a resolution in #12356 and then we can go forward.

@glemaitre glemaitre changed the title documentation for default values in linear_models [WIP] DOC documentation for default values in linear_models Jul 30, 2019
@shahules786
Copy link
Author

@glemaitre @adrinjalali This was my first PR to sklearn,I would like to contribute more...

@glemaitre
Copy link
Member

@maverick100 Do not hesitate to pick up another issue from the issue tracker. We have plenty :)

@cmarmo
Copy link
Contributor
cmarmo commented Sep 18, 2020

Hi @shahules786 , #12356 has been merged but in the meanwhile default values for PassiveAggressive have already been fixed via other PRs. Sorry for that.
I will close this PR but you are more than welcome to contribute, for example picking one of the "help wanted" stalled PRs. Thanks for your patience!

@cmarmo cmarmo closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahules786 @rth @amueller @adrinjalali @glemaitre @cmarmo
0