8000 DOC specify default of error_score in cross_validate by alexitkes · Pull Request #14488 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC specify default of error_score in cross_validate #14488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2020
Merged

DOC specify default of error_score in cross_validate #14488

merged 4 commits into from
Sep 18, 2020

Conversation

alexitkes
Copy link
Contributor

Added default value documentation for some parameters of KFold, StratifiedKFold and cross_validate, just like it was previously done for parameters of some linear models (see #14452).

@glemaitre glemaitre changed the title Document default values for KFold, StratifiedKFold and cross_validate [WIP] DOC Document default values for KFold, StratifiedKFold and cross_validate Jul 30, 2019
@glemaitre
Copy link
Member

@alexitkes I might advise waiting for a resolution regarding the standard that we would like to follow regarding the docstring formatting. We might not review this PR before having made a choice in #12356. You will need to be patient then :)

@alexitkes alexitkes force-pushed the alexitkes/cv-docstrings branch from bfb4bc6 to 9177d07 Compare October 7, 2019 15:45
@cmarmo
Copy link
Contributor
cmarmo commented Sep 18, 2020

Hi @alexitkes , I know it has been a while... sorry for that.
#12356 has been merged, but in the meanwhile some of your fixes have already been included via other PRs.
Still, error_score has not been fixed. Are you interested in finalizing this PR fixing error_score default values?
Thanks for your work so far, anyway.

@alexitkes alexitkes force-pushed the alexitkes/cv-docstrings branch from 9177d07 to 660bfdd Compare September 18, 2020 19:38
@alexitkes
Copy link
Contributor Author

@cmarmo Ok, rebased it.

NicolasHug
NicolasHug approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member
@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexitkes

@NicolasHug NicolasHug changed the title [WIP] DOC Document default values for KFold, StratifiedKFold and cross_validate DOC specify default of error_score in cross_validate Sep 18, 2020
@NicolasHug NicolasHug merged commit 8b68ea1 into scikit-learn:master Sep 18, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alexitkes @jayzed82
DOC specify default of error_score in cross_validate (scikit-learn#14488
6fcd509 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
module:model_selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexitkes @glemaitre @cmarmo @NicolasHug
0