8000 [MRG] DOC Remove mentions of removed AUTHORS.rst file by jacquerie · Pull Request #12262 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG] DOC Remove mentions of removed AUTHORS.rst file #12262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jacquerie
Copy link
Contributor

What does this implement/fix? Explain your changes.

Since #11708 was merged the links to the AUTHORS.rst file in the README have inadvertently been broken. This PR amends them to point to the "Authors" section of the "About us" page of the website. It also removes this file from the MANIFEST.

Any other comments?

Apologies for the trivial contribution! I promise that my next contribution will be more substantial...

8000
@NicolasHug
Copy link
Member

Good catch, as far as I can tell there is no other mention of AUTHORS.rst in the repo so LGTM.

Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jacquerie

@qinhanmin2014 qinhanmin2014 merged commit 24aa6b8 into scikit-learn:master Oct 4, 2018
@jacquerie jacquerie deleted the remove-mentions-of-authors-file branch October 4, 2018 11:29
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0