-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[WIP] Add Versionadded tags #12187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Versionadded tags #12187
Conversation
@@ -36,6 +36,8 @@ def set_config(assume_finite=None, working_memory=None): | |||
to this number of MiB (per job when parallelised), often saving both | |||
computation time and memory on expensive operations that can be | |||
performed in chunks. Global default: 1024. | |||
|
|||
.. versionadded:: 0.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was in 0.20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes more sense to document each parameter than the overall function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes more sense to document each parameter than the overall function.
Honestly this is exactly what I prefer, not sure whether Andreas will agree with us. @jnothman should I push a commit or let's leave it as it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I would do both, but yes, parameters seems more important.
@rth It's added in 0.19. Previously, it's in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @leeyjjoel
You are right @qinhanmin2014, parameter were added later.. |
Sigh, the format is not correct and we put it in the wrong place. Apologies for merging this one. I'll push a commit to fix it. |
Fine, I think this will be a good solution here. Will push a commit. |
Reference Issues/PRs
Fixes #12081.
What does this implement/fix? Explain your changes.
This PR adds adds tags to track the version of each function
Any other comments?