8000 DOCS: noting y is present in one-class fit methods merely for API consistency by raamana · Pull Request #11939 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOCS: noting y is present in one-class fit methods merely for API consistency #11939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 30, 2018
Merged

DOCS: noting y is present in one-class fit methods merely for API consistency #11939

merged 5 commits into from
Aug 30, 2018

Conversation

raamana
Copy link
Contributor
@raamana raamana commented Aug 29, 2018 •
edited by jnothman
Loading

This is a continuation of and closes #11933

albertcthomas
albertcthomas reviewed Aug 29, 2018
View reviewed changes
Copy link
Contributor
@albertcthomas albertcthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raamana! Could you do the same for fit_predict in OutlierMixin here?

@raamana
Copy link
Contributor Author
raamana commented Aug 29, 2018

NP. Good pointer, fixed it for OutlierMixin. I also took the liberty to make the same changes in few other places. As Joel pointed out in #11933 , this problem exists in many other places, where clustering is involved. While Ignored is better than None, but mentioning the reason why developers chose this (everywhere its used) would be the way to go.

jnothman
jnothman approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not checked this is complete, but it's a helpful change. Thanks!

@jnothman jnothman merged commit 1a61f50 into scikit-learn:master Aug 30, 2018
@raamana
Copy link
Contributor Author
raamana commented Aug 30, 2018

Yay! My first contribution into the mighty scikit-learn ;).. You’re welcome - looking fwd to contribute even more!

jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Aug 30, 2018
@raamana @jnothman
DOCS: noting y is present in one-class fit methods merely for API con…
c225cf0 
…sistency (scikit-learn#11939)
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Sep 17, 2018
@raamana @jnothman
DOCS: noting y is present in one-class fit methods merely for API con…
8338b31 
…sistency (scikit-learn#11939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertcthomas albertcthomas albertcthomas left review comments

@jnothman jnothman jnothman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raamana @jnothman @albertcthomas
0