[MRG+2] Remove nose-specific _named_check #10160
Conversation
which was a nose-specific thing to have good names for tests using yield
It depends what you mean by dropping nosetests. Since #9840, we do not run nose in the CIs and the doc has been updated to use pytest. Technically you can still run the tests with nose if you really want to ;-). |
I'll probably look at this at one point. I don't think it is that urgent because yield tests will be removed in pytest 4. |
|
Is there a way to print better names with pytest? Do we need to use parametrized tests for that? Right now the messages are uninformative. |
|
lgtm, though we need to replace it by a mechanism that works with pytest |
Yes parametrized tests is the way forward, for the nice naming you can do that with test ids: |
|
Why did you revert? |
|
Seems to be local only |
|
Yep that was a misclick (clicked on revert rather than delete branch), fortunately it was in PR mode, so it just created a branch. |
|
I think there's no hurry to use parameterize, but we should encourage it,
and familiarise ourselves with that pattern, for new contributions. perhaps
we also need to exemplify it a little, updating old tests, to give
contributors something to emulate.
|
which was a nose-specific thing to have good names for tests using yield
It was a nose-specific thing to have good names for tests using yield.
_named_checkhas no effect for pytest. See #7317 for example for more details.