8000 Bug in regression metric · Issue #9998 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Bug in regression metric #9998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pseudotensor opened this issue Oct 25, 2017 · 1 comment
Closed

Bug in regression metric #9998

pseudotensor opened this issue Oct 25, 2017 · 1 comment

Comments

@pseudotensor
Copy link
pseudotensor commented Oct 25, 2017

https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/metrics/regression.py#L313

E..g, wrong in case y_true>0 but y_pred<=0. One should have:

if not (y_true >= 0).all() or not (y_pred >= 0).all():

or

if not ((y_true >= 0).all() and (y_pred >= 0).all()):

@jnothman
Copy link
Member

Duplicate of #9963. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
386C
Development

No branches or pull requests

2 participants
0