8000 estimator_checks use isinstance(estimator, ClassifierMixin) · Issue #9475 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

estimator_checks use isinstance(estimator, ClassifierMixin) #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jnothman opened this issue Aug 2, 2017 · 1 comment · Fixed by #9482
Closed

estimator_checks use isinstance(estimator, ClassifierMixin) #9475

jnothman opened this issue Aug 2, 2017 · 1 comment · Fixed by #9482
Labels
Easy Well-defined and straightforward way to resolve

Comments

@jnothman
Copy link
Member
jnothman commented Aug 2, 2017

Some estimator checks use isinstance(estimator, ClassifierMixin). They should use base.is_classifier instead. Or we should implement __instancecheck__ on ClassifierMixin so that they are equivalent.
@amueller
Copy link
Member
amueller commented Aug 2, 2017

I think we should go with the first.

@amueller amueller added Easy Well-defined and straightforward way to resolve Need Contributor labels Aug 2, 2017
@minghui-liu minghui-liu mentioned this issue Aug 2, 2017
Merged
@TomDLT TomDLT mentioned this issue Aug 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Use base.is_classifier instead of isinstance minghui-liu/scikit-learn
2 participants
@jnothman @amueller
0