8000 sphinx gallery failing on 0.18.2 · Issue #9186 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

sphinx gallery failing on 0.18.2 #9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Jun 20, 2017 · 17 comments
Closed

sphinx gallery failing on 0.18.2 #9186

amueller opened this issue Jun 20, 2017 · 17 comments

Comments

@amueller
Copy link
Member

Can anyone with sphinx-gallery expertise help me on this one:
https://circleci.com/gh/scikit-learn/scikit-learn/11492?utm_campaign=build-failed&utm_medium=email&utm_source=notification

It's from me trying to do a 0.18.2 release: #9167

I tried to upgrade sphinx-gallery, but that broke even more....
@Titan-C
Copy link
Contributor
Titan-C commented Jun 20, 2017

Is this done on a clean docs build? From the error I see it seems to look for a html file that does not exists anymore.

@amueller
Copy link
Member Author

It's on Circle. Is there a cache? I just did "rebuilt without cache", let's see if that does anything.
But it should make clean beforehand....

@Titan-C
Copy link
Contributor
Titan-C commented Jun 20, 2017

when I push to rebuild the docs for sphinx gallery the commit message starts with
[doc build]

@amueller
Copy link
Member Author

hm they are built here even the marker is not there... but whether it's there or not, it should not fail...
I think because the branch is called 0.18.2 (which maybe I shouldn't have done) it builds everything, including pdf and examples.

@Titan-C
Copy link
Contributor
Titan-C commented Jun 20, 2017

@amueller I don't understand your last comment

@amueller
Copy link
Member Author

The name of the branch I'm on in #9167 is 0.18.2. That changes how the docs are built:
https://github.com/scikit-learn/scikit-learn/blob/master/build_tools/circle/build_doc.sh#L75

@Titan-C
Copy link
Contributor
Titan-C commented Jun 20, 2017

Other thing that I just notice is that scikit-learn/0.18.X is still on Sphinx-Gallery 0.1.2 which still does have the patch to use Sphinx 1.5 which came in sphinx-gallery 0.1.7. Thus you should keep pinning Sphinx to 1.4

@amueller
Copy link
Member Author

Sphinx 1.4 breaks with current docutils and so I would have to pin that, too, and maybe other stuff.
You mean this fix for 1.5, right:
https://github.com/scikit-learn/scikit-learn/pull/9167/files#diff-cc293bc3f7189fb04db7447b6ffbc49fL138

It just cherry-picked it.

@amueller
Copy link
Member Author

It looks like the built might be going through now, which is really strange. the circle cache should really not be breaking the built... hm...

@amueller
Copy link
Member Author

Never mind, still failing:
https://circleci.com/gh/scikit-learn/scikit-learn/11494

@Titan-C
Copy link
Contributor
Titan-C commented Jun 20, 2017

What you cherrypicked is for Sphinx 1.6, but you don't have the fixes for Sphinx 1.5. And know that I review The breaking change of Sphinx 1.5. It makes sense that the docs build cannot find files after the build.

That is the build will not succeed in Sphinx>1.4 unless you have Sphinx-Gallery>=0.1.7
That means you at least need to port to this branch all the changes that came with PR #7986

@amueller
Copy link
Member Author

Hm but that merge didn't have the full diff because there was another upgrade before, right?

@amueller
Copy link
Member Author

I guess I'll try to pin sphinx=1.4 and docutils and whatever else is needed.

@Titan-C
Copy link
Contributor
Titan-C commented Jun 20, 2017 •
edited
Loading

Yes, I just realized that. That PR updates from 0.1.4 to 0.1.7. So you need even the previous PR #7354 too

@amueller
Copy link
Member Author

If only we could just install a current version like a normal library and not vendor it ;)

@Titan-C
Copy link
Contributor
Titan-C commented Jun 20, 2017

PR #7354 and PR #7986 barely touch things out of the package itself. But you still you need the updates in css and layout which are extremely particular to scikit-learn form PR #7354, so that won't save you in this case. Aside from that I also agree that it would be simpler if you just install it as a library and not ship it in scikit-learn

@amueller
Copy link
Member Author

It's working now with a lot of pinning. Thanks for you help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amueller @Titan-C
0