8000 check_estimator fails for (non hard-coded) estimators that support 2-D y · Issue #8683 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

check_estimator fails for (non hard-coded) estimators that support 2-D y #8683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MechCoder opened this issue Apr 1, 2017 · 2 comments
Closed

check_estimator fails for (non hard-coded) estimators that support 2-D y #8683

MechCoder opened this issue Apr 1, 2017 · 2 comments
Labels
Easy Well-defined and straightforward way to resolve help wanted

Comments

@MechCoder
Copy link
Member

Description

If an external estimator supports 2-D y, then a DataConversionWarning will not be raised.

However, this will fail check_supervised_y_2d because it either expects such a warning to be raised or that the corresponding estimator is hardcoded in the global variable MULTI_OUTPUT
@MechCoder MechCoder added the Easy Well-defined and straightforward way to resolve label Apr 8, 2017
@KrMantavya
Copy link

@MechCoder I would like to work on this. Could you tell me which files i need to work on and more about the expected behaiviour of the module?

@rth rth mentioned this issue Jun 8, 2017
Closed
@amueller
Copy link
Member

Fixed by #8022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amueller @rth @MechCoder @KrMantavya
0