8000 Docstring for Gaussian Process Kernels: some mistakes · Issue #8553 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Docstring for Gaussian Process Kernels: some mistakes #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Mar 7, 2017 · 3 comments · Fixed by #8571
Closed

Docstring for Gaussian Process Kernels: some mistakes #8553

ghost opened this issue Mar 7, 2017 · 3 comments · Fixed by #8571
Labels
Easy Well-defined and straightforward way to resolve

Comments

@ghost
Copy link
ghost commented Mar 7, 2017

The docstring explanation about some kernels contradicts the implementation:

  1. Rational quadratic kernel: in the introduction page http://scikit-learn.org/stable/modules/gaussian_process.html#gp-kernels, the power is "alpha", but in the implementation, it is -1*alpha. (see line 1470).

  2. "ExpSineSquare" kernel: in the docstring (http://scikit-learn.org/stable/modules/gaussian_process.html#gp-kernels) the positions of parameter "l" and power of 2 are wrong. It should be "exp(-2(sin(pi/p *d(x_i,x_j))/l)^2)", rather than "exp(-2sin(pi/p *d(x_i,x_j))/l)^2".
@MechCoder
Copy link
Member

Nice catch. You are right, thanks!

@MechCoder MechCoder added Easy Well-defined and straightforward way to resolve Need Contributor labels Mar 7, 2017
@rishikksh20
Copy link
Contributor

@fafadada if you are interested to resolve this issue, go ahead. Otherwise I can raise a PR.

@jmetzen
Copy link
Member
jmetzen commented Mar 8, 2017

Thanks for this issue!

@rishikksh20 rishikksh20 mentioned this issue Mar 10, 2017
Merged
MechCoder pushed a commit that referenced this issue Mar 13, 2017
@rishikksh20 @MechCoder
Correct formulas in Doc of Gaussian Process Kernels (#8571)
7d1afd7 
Correct the Rational quadratic kernel and ExpSineSquare
kernel formulas.

Issue: #8553
@Przemo10 Przemo10 mentioned this issue Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this issue Mar 26, 2017
@rishikksh20 @herilalaina
Correct formulas in Doc of Gaussian Process Kernels (scikit-learn#8571)
4d89136 
Correct the Rational quadratic kernel and ExpSineSquare
kernel formulas.

Issue: scikit-learn#8553
massich pushed a commit to massich/scikit-learn that referenced this issue Apr 26, 2017
@rishikksh20
Correct formulas in Doc of Gaussian Process Kernels (scikit-learn#8571)
723a8db 
Correct the Rational quadratic kernel and ExpSineSquare
kernel formulas.

Issue: scikit-learn#8553
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this issue Jun 14, 2017
@rishikksh20 @Sundrique
Correct formulas in Doc of Gaussian Process Kernels (scikit-learn#8571)
8e4117a 
Correct the Rational quadratic kernel and ExpSineSquare
kernel formulas.

Issue: scikit-learn#8553
NelleV pushed a commit to NelleV/scikit-learn that referenced this issue Aug 11, 2017
@rishikksh20 @NelleV
Correct formulas in Doc of Gaussian Process Kernels (scikit-learn#8571)
4f6c31e 
Correct the Rational quadratic kernel and ExpSineSquare
kernel formulas.

Issue: scikit-learn#8553
paulha pushed a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017
@rishikksh20 @paulha
Correct formulas in Doc of Gaussian Process Kernels (scikit-learn#8571)
11a9d98 
Correct the Rational quadratic kernel and ExpSineSquare
kernel formulas.

Issue: scikit-learn#8553
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this issue Nov 15, 2017
@rishikksh20 @maskani-moh
Correct formulas in Doc of Gaussian Process Kernels (scikit-learn#8571)
358f275 
Correct the Rational quadratic kernel and ExpSineSquare
kernel formulas.

Issue: scikit-learn#8553
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this issue Dec 18, 2017
@rishikksh20
Correct formulas in Doc of Gaussian Process Kernels (scikit-learn#8571)
4b6e6f5 
Correct the Rational quadratic kernel and ExpSineSquare
kernel formulas.

Issue: scikit-learn#8553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG + 1] Correct formulas in Doc of Gaussian Process Kernels
3 participants
@jmetzen @MechCoder @rishikksh20
0