8000 Unbundling joblib · Issue #8494 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Unbundling joblib #8494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheChymera opened this issue Mar 2, 2017 · 4 comments
Closed

Unbundling joblib #8494

TheChymera opened this issue Mar 2, 2017 · 4 comments

Comments

@TheChymera
Copy link

Scikit_learn seems to be shipping a joblib distribution, which causes the usual overhead and confusion associated with bundling. Gentoo - for instance - has been editing the sources of scikit_learn to remove all imports of scikit_learn's joblib and instead import the system joblib for a long time now, and the software runs and passes tests successfully.

If scikits_learn may need a specific joblib version at some point, that can be more appropriately handled by restricting the dependency via a minimum or maximum version.

As part of brainhack2017 in Zurich I would be happy to help by either (in my order of preference):

  • removing the shipped joblib and its associated code entirely,
  • preferentially importing the system joblib, and adding except statements that default to the bundled joblib import,
  • preferentially importing the bundled joblib, and adding an except statement defaulting to the system joblib. This latter suggestion simply makes it easier to maintain unbundled distributions of scikit_learn - by only having to not install sklearn/externals/joblib.

Could you please let me know what contribution addressing this issue would be best received?
@GaelVaroquaux
Copy link
Member
GaelVaroquaux commented Mar 2, 2017 via email

@TheChymera
Copy link
Author

What advantage does bundling it provide? For the aforementioned reasons it has a number of drawbacks.

@jnothman
Copy link
Member
jnothman commented Mar 3, 2017 via email

@TheChymera TheChymera mentioned this issue Mar 26, 2017
Merged
@rth rth mentioned this issue Oct 23, 2018
Closed
@rth
Copy link
Member
rth commented Jun 20, 2019

Fixed since v0.21.0.

@rth rth closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jnothman @GaelVaroquaux @rth @TheChymera
0