the contradiction in docstring in LocalOutlierFactor class #8048
Labels
Comments
|
offer a PR to fix it?
…On 13 December 2016 at 18:56, AlanJun ***@***.***> wrote:
Description
the docstring of function "fit_predict" in LocalOutlierFactor class says
"returns the labels
(1 inlier, -1 outlier)"
however in the latter Returns part, it says "Returns 1 for
anomalies/outliers and -1 for inliers"
kind of misleading, fortunately it's easy to fix
Thx
Steps/Code to Reproduce Expected Results Actual Results Versions
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8048>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAEz68r26ibQuwz63AQKg3mWYjGPbtyoks5rHk_FgaJpZM4LLb8z>
.
|
|
Hi, I'd like to take this on? It seems like just a documentation fix. |
|
Sorry if this is a beginner question, but I'd like to know if there may some differences in versions? I tried to replicate this example:
|
|
This estimator is only recently added to master.
…On 15 December 2016 at 14:11, Don86 ***@***.***> wrote:
Sorry if this is a beginner question, but I'd like to know if there may
some differences in versions? I tried to replicate this example
<http://scikit-learn.org/dev/auto_examples/neighbors/plot_lof.html>:
import numpy as np
from sklearn.neighbors import LocalOutlierFactor
*Error*: cannot import name 'LocalOutlierFactor'
import sklearn
import sys
import platform
print("sklearn version:",sklearn.__version__)
print("Py version:", platform.python_version())
sklearn version: 0.17
Py version: 3.5.1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8048 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz60iWWakLdbXu0XemsFJf7JMD8WiFks5rIK_cgaJpZM4LLb8z>
.
|
|
Made a PR, seems that it was combined with #8039. |
|
you should be using a separate branch for each PR.
…On 15 December 2016 at 15:05, Don86 ***@***.***> wrote:
Made a PR, seems that it was combined with #8039
<#8039>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8048 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz68LIDWGpGVqsL0oLBDWb8Y8WGO5jks5rILyRgaJpZM4LLb8z>
.
|
|
please try to keep #8039 to its own topic.
…On 15 December 2016 at 15:53, Joel Nothman ***@***.***> wrote:
you should be using a separate branch for each PR.
On 15 December 2016 at 15:05, Don86 ***@***.***> wrote:
> Made a PR, seems that it was combined with #8039
> <#8039>.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#8048 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAEz68LIDWGpGVqsL0oLBDWb8Y8WGO5jks5rILyRgaJpZM4LLb8z>
> .
>
|
|
Changes that don't belong in #8039 have been rolled back. |
|
Hi, is this issue still open? |
|
Nope, PR merged in #8059. This issue can be closed, actually. |
|
Please close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
the docstring of function "fit_predict" in LocalOutlierFactor class says "returns the labels
(1 inlier, -1 outlier)"
however in the latter Returns part, it says "Returns 1 for anomalies/outliers and -1 for inliers"
kind of misleading, fortunately it's easy to fix
Thx
Steps/Code to Reproduce
Expected Results
Actual Results
Versions
The text was updated successfully, but these errors were encountered: