Closed
Description
I'm trying to make our common tests work on instances instead of classes in #8022 - this is a prerequisite to implement instance-level estimator tags and get rid of the hard-coded classes.
I ran into an interesting issue.
Instead of instantiating an estimator, I clone it. I expected that parameters after cloning are equal (==
) to before cloning. They are not.
from sklearn.cluster import AgglomerativeClustering
from sklearn.base import clone
agg = AgglomerativeClustering()
agg2 = clone(agg)
agg.memory == agg2.memory
False
Question: should this condition be true? I think it's not actually an issue for changing the tests, but it seemed somewhat weird to me.