10000 ensure that estimators only add private attributes and attributes with trailing _ · Issue #7763 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ensure that estimators only add private attributes and attributes with trailing _ #7763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Oct 26, 2016 · 5 comments · Fixed by #7846
Closed

ensure that estimators only add private attributes and attributes with trailing _ #7763

amueller opened this issue Oct 26, 2016 · 5 comments · Fixed by #7846
Labels
Easy Well-defined and straightforward way to resolve

Comments

@amueller
Copy link
Member

Once #7553 is merged, we should add a test that ensures that fit only adds attributes that are either private (start with an _) or end with a _.
@amueller amueller added Easy Well-defined and straightforward way to resolve Need Contributor labels Oct 26, 2016
@RonakMehta25
Copy link

Hello amueller , I am interested in contributing to scikit project .i am new to the community. Can you explain how should i contribute to this issue

@amueller
Copy link
Member Author
amueller commented Nov 1, 2016

If you want to tackle this, you should wait till #7553 is merged

@mayank-20-nayyar
Copy link

hello amueller, is this issue still open? i would like to contribute to SciKit and I am new in open-source contribution so could you please guide me on working on this issue.

@kiote
Copy link
Contributor
kiote commented Nov 7, 2016

I think I can do something here, either fix this issue myself, or "guide" others since I have at least some idea, how it should be done.

@jnothman
Copy link
Member
jnothman commented Nov 7, 2016

I'd be happy to see you pursue this @kiote. Apologies to @mowgli-m: please do find another issue to get started with.

@kiote kiote mentioned this issue Nov 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG + 1] Add check for estimator: parameters not modified by fit
5 participants
@jnothman @kiote @amueller @RonakMehta25 @mayank-20-nayyar
0