8000 check_estimator should allow NaNs? · Issue #7737 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content
check_estimator should allow NaNs? #7737
Closed
@chkoar

Description

@chkoar

In imbalanced-learn we have cases (e.g. scikit-learn-contrib/imbalanced-learn#157) where some samplers like RandomUnderSampler and RandomOverSampler could naturally accept NaNs for X because the values of the X are irrelevant to the random sampling itself. If we modifiy the Random*Samplers to accept NaNs the check_estimator tests fall for them.

So we have two options:

  • Skip the check_estimator tests for the Random*Samplers
  • Do not accept the NaNs at all and document it clearly.

Any workaround on this? What are your thoughts?

This issue in general is related to #6981.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0