8000 arguments to fit in "rolling your own estimator" · Issue #7142 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

arguments to fit in "rolling your own estimator" #7142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Aug 4, 2016 · 3 comments
Closed

arguments to fit in "rolling your own estimator" #7142

amueller opened this issue Aug 4, 2016 · 3 comments
Labels
Documentation Easy Well-defined and straightforward way to resolve

Comments

@amueller
Copy link
Member
amueller commented Aug 4, 2016

It came up in #7136 that the dev docs are not super explicit what parameters should be passed to fit.
Basically, the rule is that should only be those that have shape n_samples and need to be sliced in cross-validation. The rest should go into __init__ (also maybe mention that cross-validation does allow this slicing).

For transform and predict we don't usually have parameters, though there could be times when that would be helpful, like thresholds for prediction / feature selection. We haven't really handled that consistently so far, maybe we should advise to generally avoid parameters to transform and predict, as people can always do estimator.set_params(stuff=1) or estimator.stuff = 1
@amueller amueller added Easy Well-defined and straightforward way to resolve Documentation Need Contributor labels Aug 4, 2016
@shanglun
Copy link
shanglun commented Aug 6, 2016

I can take this one. Looks fairly simple.

@shanglun shanglun mentioned this issue Aug 7, 2016
Closed
@shanglun
Copy link
9084 shanglun commented Aug 7, 2016

Hello, I have submitted a pull request implementing this change. Please reach out if you need anything. Thank you!

@cmarmo
Copy link
Contributor
cmarmo commented Sep 29, 2020

As said in #7156-comment documentation has changed since this issue was opened. I'm closing it. Feel free to open a new one if the issue is still present in the new version.

@cmarmo cmarmo closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amueller @cmarmo @shanglun
0