8000 Make sphinx run without errors, then make sphinx errors stop on continuous integration · Issue #7096 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Make sphinx run without errors, then make sphinx errors stop on continuous integration #7096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Jul 27, 2016 · 4 comments
Closed

Make sphinx run without errors, then make sphinx errors stop on continuous integration #7096

amueller opened this issue Jul 27, 2016 · 4 comments
Labels
Build / CI Documentation

Comments

@amueller
Copy link
Member

I think we attempted this before, but didn't get through. Is there any code left?
Master has a bunch of errors again :-/
@doshyt
Copy link
Contributor
doshyt commented Jul 28, 2016 •
edited
Loading

@amueller
Hi, I'm a build and integration engineer at my daytime job :) So I would love to take a look at the issue if you give me the initial guidance regarding the build system organization, so I would have a starting point.
As I understood so far, it is a Travis CI environment issue

@lesteve
Copy link
Member
lesteve commented Jul 28, 2016 •
edited
Loading

@amueller is that the same thing as #6025?

@lesteve
Copy link
Member
lesteve commented Jul 28, 2016

If both issues are the same, it is worth reading #6030 (comment):

Sphinx can be told to error when there are warnings. See https://github.com/nilearn/nilearn/pull/871/files

However, our experience with nilearn doing this has been a bit painful: most people do not know how to fix the build errors (and to be fair, they can be quite subttle), so the maintainers end up finishing of the PRs.

@amueller
Copy link
Member Author

closing as duplicate of #6025, considering seeing a doctor for early-onset dementia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amueller @lesteve @doshyt
0