8000 Testing pipeline with check_estimator · Issue #6594 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Testing pipeline with check_estimator #6594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cphang99 opened this issue Mar 26, 2016 · 2 comments
Closed

Testing pipeline with check_estimator #6594

cphang99 opened this issue Mar 26, 2016 · 2 comments
Labels
API

Comments

@cphang99
Copy link

Hi!

I've been looking at pipelines and as a first step trying to test pipeline with check_estimator. As we can only pass the pipeline object, and there are no default parameters for 'steps', the check_parameters_default_constructible check fails as a no-arg constructor is not possible.

import sklearn.utils.estimator_checks
import sklearn.pipeline
sklearn.utils.estimator_checks.check_estimator(sklearn.pipeline.Pipeline)
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python2.7/dist-packages/sklearn/utils/estimator_checks.py", line 212, in check_estimator
check_parameters_default_constructible(name, Estimator)
File "/usr/local/lib/python2.7/dist-packages/sklearn/utils/estimator_checks.py", line 1378, in check_parameters_default_constructible
estimator = Estimator()
TypeError: init() takes exactly 2 arguments (1 given)

Is it possible to modify estimator_checks to accomodate this? (possibly to cater for other custom meta-estimators and pipelines?)

Many thanks
@jnothman jnothman added the API label Mar 31, 2016
@jnothman
Copy link
Member

Closely related #6423. Possible solution in #6599.

@amueller
Copy link
Member

fixed in #9019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jnothman @amueller @cphang99
0