8000 regression in silhouette score · Issue #5988 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

regression in silhouette score #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Dec 9, 2015 · 6 comments
Closed

regression in silhouette score #5988

amueller opened this issue Dec 9, 2015 · 6 comments
Labels
Bug
Milestone
0.19

Comments

@amueller
Copy link
Member
amueller commented Dec 9, 2015

Apparently I introduced a last minute regression here: f0f174b#commitcomment-14775170

Not sure if that deserves a backport / bugfix release?
@amueller amueller added the Bug label Dec 9, 2015
@Sentient07
Copy link
Contributor

@amueller Can i open a PR for this ?

@raghavrv
Copy link
Member

Please go ahead!

@Sentient07
Copy link
Contributor

@rvraghav93 quick confirmation, i need to get that return statement back and ensure all the tests passes, right ?

@raghavrv
Copy link
Member

That + a regression test which will raise an error in master but not in ur branch :)

@Sentient07 Sentient07 mentioned this issue Dec 26, 2015
Closed
@Sentient07
Copy link
Contributor

@rvraghav93 , i got nan instead of 1 as described in the comment, but upon reverting the specified code, silhouette_samples returned 0. So i've written the test to check if it's not "nan"

@jnothman jnothman mentioned this issue Aug 11, 2016
Closed
10 tasks
@jnothman jnothman mentioned this issue Sep 15, 2016
Merged
@amueller amueller modified the milestone: 0.19 Sep 29, 2016
@amueller
Copy link
Member Author

closed in #7438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.19
Development

Successfully merging a pull request may close this issue.

[MRG] Fix regression in silhouette_score for clusters of size 1 Sentient07/scikit-learn
3 participants
@amueller @Sentient07 @raghavrv
0