8000 Clicking on Contributing Documentation leads to 404 error. · Issue #5933 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Clicking on Contributing Documentation leads to 404 error. #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
souravsingh opened this issue Nov 28, 2015 · 21 comments
Closed

Clicking on Contributing Documentation leads to 404 error. #5933

souravsingh opened this issue Nov 28, 2015 · 21 comments

Comments

@souravsingh
Copy link
Contributor

I was trying to look into the documentation and found that clicking on Contributing in the Documentation drop-down menu leads to a 404 error.Is it due to the sphinx build?
@raghavrv
Copy link
Member

Hey @souravsingh! The page seems to be working from my end - http://scikit-learn.org/stable/developers/contributing.html

@souravsingh
Copy link
Contributor Author

It happened when I tried the drop-down menu in Documentation.The image for the link is here and the exact error is here

@souravsingh
Copy link
Contributor Author

If I click on Contributing on the drop-down list in Documentation.It redirects to this link which is where the error shows up.

@nelson-liu
Copy link
Contributor

Seems like my comment did not post, but I can indeed verify that there is a dead link. I'm looking into why it is so right now.

@nelson-liu
Copy link
Contributor

Weird, seems like on my machine building the local HTML uses a different layout.html than the current live site on the web. When building it locally, there is no 404 but the link headers are outdated. Is the current live webpage using this as its theme (https://github.com/scikit-learn/scikit-learn/blob/master/doc/themes/scikit-learn/layout.html) ? It does not seem as if it is.

@nelson-liu
Copy link
Contributor

ah, seems like there's a dev version of the site (see: #5890). Probably just a matter of missing /index (developers vs developers/index). @rvraghav93 could you let me know if I am correct?

@raghavrv
Copy link
Member

Ah I see... The dropdown box link points to http://scikit-learn.org/stable/developers.html, instead of http://scikit-learn.org/stable/developers/contributing.html

@remyleone
Copy link
Contributor

@rvraghav93 If you do a make linkcheck inside /doc you can see all the broken/redirect links (internal and external)

Here is a little excerpt of what you get : https://gist.github.com/5de1b0c9dc83610a586d

@raghavrv
Copy link
Member
raghavrv commented Dec 3, 2015

Whoa!! This needs to be fixed! @nelson-liu Would you like to take that up and fix them too?

@nelson-liu
Copy link
Contributor

Sure, I'd be happy to help. Is there a different live site and development
site though?

On Wed, Dec 2, 2015, 5:36 PM Raghav R V notifications@github.com wrote:

Whoa!! This needs to be fixed! @nelson-liu https://github.com/nelson-liu
Would you like to take that up and fix them too?

—
Reply to this email directly or view it on GitHub
#5933 (comment)
.

@raghavrv
Copy link
Member
raghavrv commented Dec 3, 2015

Yes the "dev" site (is supposed to) update every 1 hour from master and the "stable" site is based on the last stable version released...

@nelson-liu
Copy link
Contributor

Ah, got it. That explains a lot. Thanks for the info, and I'll take up this
task.

On Wed, Dec 2, 2015, 5:42 PM Raghav R V notifications@github.com wrote:

Yes the "dev" site http://scikit-learn.org/dev/ (is supposed to) update
every 1 hour from master and the "stable" site
http://scikit-learn.org/stable/ is based on the last stable version
released...

—
Reply to this email directly or view it on GitHub
#5933 (comment)
.

@nelson-liu
Copy link
Contributor

@sieben is there any way to run make linkcheck without running the examples?

@remyleone
Copy link
Contributor

I'm not sure.i have a fix for broken links and redirected. But i don't know
how to make Travis check broken links without too much false negatives

Le sam. 5 déc. 2015 11:49, Nelson Liu notifications@github.com a écrit :

@sieben https://github.com/sieben is there any way to run make
linkcheck without running the examples?

—
Reply to this email directly or view it on GitHub
#5933 (comment)
.

@nelson-liu
Copy link
Contributor

@rvraghav93 @sieben when attempting to run linkcheck, I get the following error: 'IOError: [Errno 2] No such file or directory: u'/Users/nelsonliu/Documents/Github/scikit-learn/doc/_build/linkcheck/searchindex.js'' Perhaps it is related to: #3830?

@remyleone
Copy link
Contributor

@nelson-liu Let's go fix this on a PR. I did some work #5968 let's move the discussion there.

@amueller amueller mentioned this issue Dec 8, 2015
Closed
@amueller
Copy link
Member
amueller commented Dec 8, 2015

fixed in 0e5c194

@amueller
Copy link
Member
amueller commented Dec 8, 2015

now someone only needs to rebuild the 0.17 website and upload it again....

@amueller
Copy link
Member
amueller commented Dec 8, 2015

hm why don't we do that automatically btw?

@amueller amueller mentioned this issue Dec 9, 2015
Closed
@amueller amueller closed this as completed Dec 9, 2015
@amueller
Copy link
Member
amueller commented Dec 9, 2015

hm maybe leave it open until we rebuild the website.

@amueller amueller reopened this Dec 9, 2015
@nelson-liu nelson-liu mentioned this issue Jan 14, 2016
Closed
@nelson-liu
Copy link
Contributor

@amueller this issue appears to be fixed, should we close?

@amueller amueller closed this as completed Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@remyleone @amueller @souravsingh @nelson-liu @raghavrv
0