8000 BUG: linear model inputs are not normalized when fit_intercept=False · Issue #5799 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content
BUG: linear model inputs are not normalized when fit_intercept=False #5799
@giorgiop

Description

@giorgiop

From #5357 as a separated issue. The problem in the code is here: normalize is not used in the branch of fit_intercept=False.

Proposed strategy, rielaborated from a discussion with @agramfort:

  • write test that would fail
  • add a boolean option to the helper for centering data, such that it can be used to normalize also when fit_intercept=False
  • use this option to pass the test
  • raise a deprecation warning when fit_intercept=False and normalize=True, suggesting to switch to normalize=False to obtain the same result. In 2 releases time, the behaviour with those options will be changed
  • fix the faulty behaviour in 2 releases

Feedback appreciated 🍻

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0