8000 Fix and refactor color handling in `DecisionBoundaryDisplay` · Issue #33115 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Fix and refactor color handling in DecisionBoundaryDisplay #33115

@AnneBeyer

Description

@AnneBeyer

This is to keep track and address several things we noticed in #33015

I will address them in follow-up PRs.

  • check number of (distinct) colors == n_classes
  • use same selection mechanism for all qualitative cmaps (that have colors)
  • refactor and unify checks (some done in from_estimator, some in plot)
  • use colors for binary problems as well (but keep viridis as default)
  • maybe even move color selection into a separate function?

Please add, if I missed anything @lucyleeow @ogrisel

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0