10000 sign error when using fmin_cobyla optimizer for gaussian processes · Issue #3180 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content
8000

sign error when using fmin_cobyla optimizer for gaussian processes #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filthysocks opened this issue May 22, 2014 · 1 comment
Closed

Comments

@filthysocks
Copy link

Hello,

the gaussian process are by default fitted using the fmin_cobyal optimizer. The optimizer is started from various random inital conditions to avoid local extrema. The problem is, the worst of those extrema is chosen in the end.

optimal_minus_rlf_value, optimal_par = self.reduced_likelihood_function(theta=optimal_theta)
# sign error 
# reduced_likelihood_function return the likelihood
# not the negative likelihood
optimal_rlf_value = - optimal_minus_rlf_value(theta=optimal_theta)

The reason it did not show up in the unit test is, that they been to easy. Even the worst local maximum was good enough to pass the test. I added a test which is more "tough" and manage to prove the current solution wrong.
Here is the solution to the unit test plotted with the current implementation:
gp_org
and fixed:
gp_with_fix

filthysocks pushed a commit to filthysocks/scikit-learn that referenced this issue May 22, 2014
@filthysocks
Copy link
Author

duplicate of #2632, which got merged.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant
0