8000 MAINT Convert `samples` parameter in Criterion classes to memory view · Issue #25004 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Convert samples parameter in Criterion classes to memory view #25004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adam2392 opened this issue Nov 22, 2022 · 1 comment · Fixed by #25005
Closed

MAINT Convert samples parameter in Criterion classes to memory view #25004

adam2392 opened this issue Nov 22, 2022 · 1 comment · Fixed by #25005
Labels
module:tree

Comments

@adam2392
Copy link
Member

Summary

The samples parameter can be changed to a Cython memoryview from its current SIZE_t* samples type.

Originally posted by @adam2392 in #24994 (comment)
@github-actions github-actions bot added the Needs Triage Issue requires triage label Nov 22, 2022
@adam2392 adam2392 mentioned this issue Nov 22, 2022
Merged
@cmarmo cmarmo added module:tree and removed Needs Triage Issue requires triage labels Nov 26, 2022
@jjerphan
Copy link
Member

Hi @adam2392, I appreciate you open an issue but I do not think it is necessary for this one: this small refactoring has already been discussed elsewhere.

@jjerphan jjerphan changed the title [MAINT, Tree] Convert samples parameter in Criterion classes to memory view MAINT Convert samples parameter in Criterion classes to memory view Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:tree
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT Handle Criterion.samples using a memoryview neurodata/scikit-learn
3 participants
@cmarmo @adam2392 @jjerphan
0