10000 Reduce warnings in test_logistic.py · Issue #24819 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Reduce warnings in test_logistic.py #24819

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lorentzenchr opened this issue Nov 3, 2022 · 1 comment · Fixed by #25469
Closed

Reduce warnings in test_logistic.py #24819

lorentzenchr opened this issue Nov 3, 2022 · 1 comment · Fixed by #25469
Labels
help wanted module:linear_model module:test-suite everything related to our tests

Comments

@lorentzenchr
Copy link
Member

Description

The tests of LogisticRegression in test_logistic.py produce currently 468 warnings (run pytest sklearn/linear_model/tests/test_logistic.py).
This is quite a lot and should be reduced.

Remark

To explore the cause for the warnings, run pytest -Werror sklearn/linear_model/tests/test_logistic.py.
@github-actions github-actions bot added the Needs Triage Issue requires triage label Nov 3, 2022
@lorentzenchr lorentzenchr added module:linear_model module:test-suite everything related to our tests help wanted and removed Needs Triage Issue requires triage labels Nov 3, 2022
@lorentzenchr lorentzenchr mentioned this issue Nov 3, 2022
Merged
@glemaitre
Copy link
Member

This would be indeed nice. Maybe a way to start would be to catch is scaling the data when solver="lbfgs" can help at suppressing warning.

@thomasjpfan thomasjpfan mentioned this issue Nov 28, 2022
Merged
@lorentzenchr lorentzenchr mentioned this issue Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted module:linear_model module:test-suite everything related to our tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TST reduce warnings in test_logistic.py lorentzenchr/scikit-learn
2 participants
@glemaitre @lorentzenchr
0