10000 Remove `sum_over_features` from `sklearn.metrics.manhattan_distances` · Issue #24597 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Remove sum_over_features from sklearn.metrics.manhattan_distances #24597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jjerphan opened this issue Oct 7, 2022 · 3 comments · Fixed by #24630
Closed

Remove sum_over_features from sklearn.metrics.manhattan_distances #24597

jjerphan opened this issue Oct 7, 2022 · 3 comments · Fixed by #24630
Labels
module:metrics

Comments

@jjerphan
Copy link
Member
jjerphan commented Oct 7, 2022

sklearn.metrics.manhattan_distances with sum_over_features=False does not return distances, looks unused, and is also unlikely used by users.

I think the behavior for sum_over_features=True should be the unique one for manhattan_distances; in this case, sum_over_features would be removed this from the public API after a deprecation cycle.

This was first discussed in #23958 (comment).
@github-actions github-actions bot added the Needs Triage Issue requires triage label Oct 7, 2022
@jjerphan jjerphan mentioned this issue Oct 7, 2022
Closed
3 tasks
@jeremiedbb
Copy link
Member

+1

@rusdes
Copy link
Contributor
rusdes commented Oct 9, 2022

I'd like to take this up. Should I just check whether the sum_over_features parameter is being used by the user and if it is, just display a deprecation warning and continue to return output for sum_over_features=True, irrespective of what the user set its value to? Or should I keep the function behavior the same and just display a deprecation warning if the user has used the parameter?

@jjerphan
Copy link
Member Author

Thanks for this proposal, @rusdes.

The suitable way to go through a deprecation cycle, that is to support sum_over_features=False for two more minor releases whilst raising a warning in this period.

Regarding introducing a deprecating cycle, see:

@rusdes rusdes mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API Remove sklearn.metrics.manhattan_distances option sum_over_features rusdes/scikit-learn
3 participants
@jjerphan @jeremiedbb @rusdes
0