8000 PERF `PairwiseDistancesReductions` initial work · Issue #22587 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

PERF PairwiseDistancesReductions initial work #22587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jjerphan opened this issue Feb 23, 2022 · 6 comments
Closed

PERF PairwiseDistancesReductions initial work #22587

jjerphan opened this issue Feb 23, 2022 · 6 comments
Labels
cython Meta-issue General issue associated to an identified list of tasks Performance

Comments

@jjerphan
Copy link
Member
jjerphan commented Feb 23, 2022 •
edited
Loading

PairwiseDistancesReductions have been introduced as a hierarchy of Cython classes to implement back-ends of some scikit-learn algorithms.

Pieces of work include:

Note that this needs not be personal work, I would be really glad having others help on this subject, proposing changes and implementations! 🙂
@github-actions github-actions bot added the Needs Triage Issue requires triage label Feb 23, 2022
@jjerphan jjerphan mentioned this issue Feb 24, 2022
Merged
10 tasks
@ogrisel ogrisel changed the title Computational back-end roadmap pairwise distances computational back-end roadmap Feb 24, 2022
@jjerphan jjerphan changed the title pairwise distances computational back-end roadmap PairwiseDistancesReductions back-end roadmap Feb 24, 2022
@jjerphan jjerphan changed the title PairwiseDistancesReductions back-end roadmap PairwiseDistancesReductions roadmap Feb 28, 2022
@jeremiedbb jeremiedbb removed the Needs Triage Issue requires triage label Mar 10, 2022
@jjerphan jjerphan mentioned this issue Jun 13, 2022
Merged
2 tasks
@jjerphan jjerphan mentioned this issue Jun 22, 2022
Closed
1 task
@jjerphan jjerphan mentioned this issue Jul 11, 2022
Closed
1 task
This was referenced Jul 19, 2022
Merged
Closed
This was referenced Jul 29, 2022
Closed
Merged
This was referenced Aug 5, 2022
Merged
Closed
Closed
@nvictus nvictus mentioned this issue Aug 10, 2022
Closed
@jjerphan jjerphan changed the title PairwiseDistancesReductions roadmap PERF PairwiseDistancesReductions roadmap Aug 25, 2022
@jjerphan jjerphan mentioned this issue Aug 26, 2022
Closed
@jjerphan jjerphan mentioned this issue Sep 29, 2022
Merged
@jjerphan jjerphan mentioned this issue Oct 21, 2022
Merged
@jjerphan jjerphan added the Meta-issue General issue associated to an identified list of tasks label Nov 18, 2022
This was referenced Nov 21, 2022
Merged
Merged
@jjerphan jjerphan mentioned this issue Dec 2, 2022
Closed
@jjerphan jjerphan mentioned this issue Jan 15, 2023
Open
@Vincent-Maladiere Vincent-Maladiere mentioned this issue Jan 21, 2023
Merged
@jjerphan
Copy link
Member Author

@Vincent-Maladiere and I are wondering about people's thoughts and opinions regarding prioritisation of the work proposed here.

For me, it is rather hard to assess what is of value. I think educating users about internals probably is more valuable than completing some of the items which are listed here.

What do people think of this? Are there any work that is not of value?

I am looking for discussions and critics. 🙂

@jjerphan jjerphan mentioned this issue Mar 9, 2023
Closed
@lorentzenchr
Copy link
Member
lorentzenchr commented Mar 10, 2023 •
edited by jjerphan
Loading

What is are the missing pieces to close this issue?

I would open dedicated issues for "Subsequent work".

@jjerphan
Copy link
Member Author
jjerphan commented Mar 10, 2023 •
edited
Loading

The two first are waiting for reviewers or authors to follow-up.

The third necessitates a stable efficient simultaneous sorting algorithm, and I think might better be reviewed after #25606.

@jjerphan jjerphan changed the title PERF PairwiseDistancesReductions roadmap PERF PairwiseDistancesReductions initial work Mar 17, 2023
@jjerphan jjerphan mentioned this issue Mar 17, 2023
Open
21 tasks
@jjerphan
Copy link
Member Author

@lorentzenchr: I have adapted the description of this issue and have opened #25888, so that this issue can be closed. What do you think?

@ogrisel
Copy link
Member
ogrisel commented Mar 23, 2023

Sounds good to me. Let's close to use new issues with shorter comment histories for subsequent work.

@ogrisel ogrisel closed this as completed Mar 23, 2023
@jjerphan
Copy link
Member Author

Thanks to every author and reviewer involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cython Meta-issue General issue associated to an identified list of tasks Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ogrisel @jjerphan @lorentzenchr @jeremiedbb
0